Conversation
This updates the repository from TypeScript 5.6 to 5.9
TS 5.6 and earlier do not understand the return type `Uint8Array<ArrayBuffer>`. tsconfig.json must be configured to `"skipLibCheck": true` to avoid compiler errors. As a consequence, the return type becomes `any`.
Uint8Array to Uint8Array<ArrayBuffer>Uint8Array to Uint8Array<ArrayBuffer>
srikrsna-buf
approved these changes
Aug 13, 2025
Merged
trentm
added a commit
to elastic/elastic-otel-node
that referenced
this pull request
Sep 4, 2025
The Uint8Array -> any change is I think coming from: bufbuild/protobuf-es#1200 It might be possible that Uint8Array<ArrayBuffer> would work as well.
trentm
added a commit
to elastic/elastic-otel-node
that referenced
this pull request
Sep 4, 2025
… 3 updates (#977) Updates `@bufbuild/protobuf` from 2.6.3 to 2.7.0 Updates `@bufbuild/buf` from 1.56.0 to 1.57.0 Updates `@bufbuild/protoc-gen-es` from 2.6.3 to 2.7.0 * re-run gen:protos and gen:types for new bufbuild deps The Uint8Array -> any change is I think coming from: bufbuild/protobuf-es#1200 It might be possible that Uint8Array<ArrayBuffer> would work as well. Co-authored-by: Trent Mick <trent.mick@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the repository from TypeScript 5.6 to 5.9.
Important
TypeScript 5.9 includes breaking changes to lib.d.ts, forcing us to change return types for some functions from
Uint8ArraytoUint8Array<ArrayBuffer>, most notablytoBinary().If you are on TypeScript 5.7 or later, you will not see any issues, because it already ships with the new type parameter.
If you are on TypeScript 5.6 and earlier, you will be affected by this change: The return type of
toBinary()will becomeany, because the compiler does not understand theUint8Array<ArrayBuffer>type.If you see a compiler error
TS2315: Type 'Uint8Array' is not genericoriginating from@bufbuild/protobuf, make sure to setskipLibCheck": truein your tsconfig.json.The rationale for this change in TypeScript is explained in microsoft/TypeScript#59417: Some APIs accept typed arrays backed by a
SharedArrayBuffer, while others only acceptArrayBuffer, and the new version of TypeScript checks the types. For example:Because of this interoperability with other APIs, it's necessary that we change our return types.